Not getting proper output for Return Statement

**MELTRONICS** · 09-02-2010

I have written the following code for the random number between 1 - 100. The following is the code that I have used :

Code:

function newGetal(){
	var g = Math.random()*100;
	g = Math.round(g);
	return g;
}
var getal = newGetal();

This program should generate a new random number between 1 - 100 every time the function is called. The problem is that it generates a new number but the number in "getal" stays the same. I think that something is wrong in the code. Anyone can help to get proper output for Return Statement..?? Please help me soon..!!

**CodGuru** · 09-02-2010

You have mentioned that the program is generating a new number but the number in "getal" stays the same. So, it means that the var getal gets assigned a value when you do var getal = newGetal(); I think that the problem is occurring because the page is remaining the same and not loading again. You can try the following code :

HTML Code:

<html lang="en">
  <head>
    <title>Test</title>
<script type="text/javascript">
function newGetal(){
	var g = Math.random()*100;
	g = Math.round(g);
	return g;
}
var getal = newGetal();
</script>
  </head>
  <body>
    <div id="testing"></div>
     <a onclick="document.getElementById('testing').innerHTML = newGetal();return false;" href="#">Random Numbers</a>
  </body>
</html>

**MELTRONICS** · 09-02-2010

Thanks for trying to solve my problem. But that didn't fixed my problem.

Code:

<input type="reset" class="button" id="reset" value="Open New" onclick="newGetal()" />

I have tried that but not able to solve my query. So please help me..!!

**opaper** · 09-02-2010

The function that you have given is called through an onclick event. It should work properly. You might have made the mistake somewhere else. Otherwise you might are missing something..!!! It would be better if you provide the complete code that you have made.!!

**MELTRONICS** · 09-02-2010

The following is my complete code :

HTML Code:

<html xmlns="http://www.javascript.org/2001/xhtml">
<head>
<title>Getting Started</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="stylesheet" type="text/css" href="getstart.css" />
<script type="text/javascript">
var teller = 0;

function newGetal(){
	teller = 0;
	var g = Math.random()*100;
	g = Math.round(g);
	return g;
}
var getal = newGetal();


function getlen(){
	var word = document.getElementById("word");
	var greek = document.getElementById("greek").value;
	teller++;
	
	if(greek> getal){
		word.value = "This value is greater."
	}
	
	if(greek< getal){
		word.value = "This value is smaller."
	}
	
	if(greek== getal){
		word.value = "CORRECT! You have got "+teller+" keep going.!"
	}
}
</script>
</head>
<body>
<div id="wrapper">
<form action="">
	<fieldset>
		<legend>Gokwerk</legend>
		<div id="text">
			<p>Do you have enough knowledge.?</p>
		</div>
		<div class="field">
			<input type="text" id="greek" name="greek" size="3" maxlength="3" />
			<label for="greek">So you know that.!!</label>
		</div>
		<div class="field">
			<input type="text" id="word" name="word" size="74" />
			<label for="word">word</label>
		</div>
		<input type="button" class="button" value="Gokken" onclick="gokken()" />
		<input type="reset" class="button" id="reset" value="Open New" onclick="newGetal()" />
		
	</fieldset>
</form>
</div>
</body>
</html>

**opaper** · 09-02-2010

The coding that I have stated below should help to fix your problem. Here is the coding :

HTML Code:

<html xmlns="http://www.javascript.org/2001/xhtml">
<head>
<title>Getting Started</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="stylesheet" type="text/css" href="gokwerk.css" />
<script type="text/javascript">
var teller = 0;

function newGetal(){
	teller = 0;
	var g = Math.random()*100;
	g = Math.round(g);
	return g;
}
var getal = newGetal();


function getlen(){
	var word = document.getElementById("word");
	var greek = document.getElementById("greek").value;
	teller++;
	
	if(greek > getal){
		word.value = "This value is greater."
	}
	
	if(greek < getal){
		word.value = "This value is smaller."
	}
	
	if(greek == getal){
		word.value = "CORRECT! You have got "+teller+" keep going.!"
	}
}
</script>
</head>
<body>
<div id="wrapper">
<form action="">
	<fieldset>
		<legend>Gokwerk</legend>
		<div id="text">
			<p>Do you have enough knowledge.?</p>
		</div>
		<div class="field">
			<input type="text" id="greek" name="greek" size="2" maxlength="2" />
			<label for="greek">So you know that.!!</label>
		</div>
		<div class="field">
			<input type="text" id="word" name="word" size="70" />
			<label for="word">Word</label>
		</div>
		<input type="button" class="button" value="Gokken" onclick="gokken()" />
		<input type="reset" class="button" id="reset" value="Open New" onclick="window.getal = newGetal()" />
		
	</fieldset>
</form>
</div>
</body>
</html>