String out of bound error

**InterNetWorKed** · 28-11-2009

Hi
I am trying a program which takes the input from the user, the program will convert all the multiple blank spaces into a single blank space. It will also create a new line after a sentence is declared. my logic is to find where is "! . or ?" in the string, if it founds one then the sentence is declared. I want to capitalize the first word of the sentence. This is my code please check it out.

Code:

public String parsentence(String sent) {
    	String t1;
    	for (int x = 0; x <= sent.length(); x ++) {
    		if ((sent.indexOf(sent.charAt(x)) + 1) != sent.length()){
    			if ((sent.charAt(x) & sent.charAt(x + 1)) == ' ') {
    				t1 = sent.charAt(x + 1) + "";
    				sent = sent.replaceFirst(t1, "");
    			}
    			if (((sent.charAt(x) == '.') || (sent.charAt(x) == '!') || (sent.charAt(x) == '?')) & (sent.charAt(x + 1) == ' ')) {
    				t1 = sent.charAt(x + 1) + "";
    				sent = sent.replaceFirst(t1, "\n");
    				sent = sent.replace(sent.charAt(x + 2), Character.toUpperCase(sent.charAt(x + 2)));
    			}
    		}
    	}
    	return sent;
    }

Any advice or suggestion on this.

**opaper** · 28-11-2009

Hi
You are trying to play with the individual characters of a string, so you must always remember that the charAt position is a zero based index. For this reason the following would not work.

Code:

x <= sent.length()

for example we will consider

Code:

test
0123

As you can see the above string is of length 4 but the index count is only 3. To sort out this you will need to change the loop, while x must be lower that the length.

Code:

for (int x = 0; x < sent.length(); x ++)

The following can give you StringOutofBoundsException

Code:

sent.charAt(x + 1)

make the required changes and I think your program will run.

**InterNetWorKed** · 28-11-2009

Hi
Thanks for your advice. Now the problem I am going through is, when is type "exam. send." two spaces after the first period. the output what i need is

Code:

Test.
Sent.

But it is displaying

Code:

Test.
 sent.

This is my modified code, please go through it and suggest me what I have to do.

Code:

 public char[] parsentence(char[] sent) {
    	sent[0] = Character.toUpperCase(sent[0]);
    	for (int x = 0; x < sent.length; x ++) {
    		if (x != (sent.length - 1)){
    			if (((sent[x] == '.') || (sent[x] == '!') || (sent[x] == '?')) && (sent[x + 1] == ' ')) {
    				sent[x + 1] = '\n';
					if (sent[x + 2] == ' ')                // SEE NOTE
						sent[x + 2] = '\u0000';     // SEE NOTE
					sent[x + 2] = Character.toUpperCase(sent[x + 2]);
    			}
    			if ((sent[x] == ' ') && (sent[x + 1] == ' ')) {
    				sent[x] = '\u0000';
    			}
    		}
    	}
    	return sent;
    }

**opaper** · 28-11-2009

Hi
I think you are making your program more complicated. I can suggest you a simple solution. Just convert to a String and after that you can use the .trim() method. I think this will make your program more efficient.