Problem of pagination

[Luis234]

I wrote a php script to display per page news. Finally in theory because in practice it is the last news that appears on all my pages. It's several days that I try but in vain. I think my code is completely wrong, but will know.

Here is my code:

  <?php 
  mysql_connect ( "localhost", "********", "**********"); 
  mysql_select_db ("**********"); 
  $numberofmessagesperpage = 1 ;
  $return = mysql_query ('SELECT COUNT (*) AS nb_messages FROM news'); 
  $data = mysql_fetch_array ($return); 
  $numberofpages = $data ['nb_messages']; 
  if (isset ($_GET ['page']) && is_int ($_GET ['page']) && $_GET ['page']> 0 && $_GET [ 'Page'] <$numberofpages) 
  $Page = $_GET ['page'] - 1; 
  else 
  $Page = 0; 
  $return = mysql_query ('SELECT * FROM news ORDER BY id DESC LIMIT'. $Page.', 1'); 
  while ($data = mysql_fetch_array ($return)) 
  {
  echo 
  '</p> 
  <div class="news"> 
  <h3>. $Data ['title']. " 
  <em> the '. date ('d/m/Y to HHI', $data [timestamp']).' </em> 
  </H3> 
  <p> '; 
  $content = nl2br (stripslashes ($data ['content'])); 
  echo $content. '</p> </div>'; 
  }
  echo 'Page:'; 
  for ($i = 1; $i <= $numberofpages; $i++) 
  {
  echo '<a href="index.php?page='. $i.'">'. $i. '</a>'; 
  }
  ?>

If you have an idea of what will not, it would be nice to me to share your ideas

[XSI]

Well firstly, in your condition, you:

is_int ($_GET ['page']) 

Even if $_GET ['page'] is a number it is not considered as integer by PHP so this test will fail whatever happens. So always be worth $Page 0.

But anyway: Most of your code is useless. In fact, you can directly use WHERE to get your page without using COUNT, LIMIT and ORDER BY ... :

  SELECT * FROM news WHERE id = $Page 

Finally, you does not escape your data to HTML output. If this is not done on purpose, there is a security hole if not done on purpose, I think it's a bad idea to use htmlspecialchariser data recording.

[Luis234]

Thank you for the info

In fact, most of my script was made from a tutorial on the site. I don't have much control over php. It was already a good start, knowing that I learned HTML and CSS from another site.

I will try to find other examples of news and re tweak my code.

[XSI]

yes HTML and CSS is good because it does not much rigor in contrast to programming languages ...

[fellah]

php generates html (even css). So I see no where is the problem. Simply that your class is defined in the css related to your html page